[PATCH] dt-bindings: net: altr,socfpga-stmmac.yaml: add minItems to iommus
Krzysztof Kozlowski
krzk at kernel.org
Tue Jul 8 23:54:24 PDT 2025
On 07/07/2025 17:44, Matthew Gerlach wrote:
> Add missing 'minItems: 1' to iommus property of the Altera SOCFPGA SoC
> implementation of the Synopsys DWMAC.
Why? Explain why you are doing thing, not what you are doing. What is
obvious which makes entire two-line commit msg redundant and useless.
Original binding had no iommus and referenced commit does not explain
why they appeared during conversion in the first place.
>
> Fixes: 6d359cf464f4 ("dt-bindings: net: Convert socfpga-dwmac bindings to yaml")
> Signed-off-by: Matthew Gerlach <matthew.gerlach at altera.com>
> ---
> Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> index c5d8dfe5b801..ec34daff2aa0 100644
> --- a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> +++ b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> @@ -59,6 +59,7 @@ properties:
> - const: ptp_ref
>
> iommus:
> + minItems: 1
> maxItems: 2
Why this has to be flexible on given SoC? This is weird. Same hardware
differs somehow?
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list