[PATCH 09/12] gpio: twl6040: set line value in .direction_out()
Bartosz Golaszewski
brgl at bgdev.pl
Mon Jul 7 00:50:22 PDT 2025
From: Bartosz Golaszewski <bartosz.golaszewski at linaro.org>
It's ok for a GPIO controller to be output-only but the .direction_out()
callback must also set the requested line value.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski at linaro.org>
---
drivers/gpio/gpio-twl6040.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpio/gpio-twl6040.c b/drivers/gpio/gpio-twl6040.c
index b9c0d54d12f43242444f12a2bd8b6988d1511466..b2196b62b528cd0a2df2c4a4c4869ad172d6e2cd 100644
--- a/drivers/gpio/gpio-twl6040.c
+++ b/drivers/gpio/gpio-twl6040.c
@@ -37,13 +37,6 @@ static int twl6040gpo_get_direction(struct gpio_chip *chip, unsigned offset)
return GPIO_LINE_DIRECTION_OUT;
}
-static int twl6040gpo_direction_out(struct gpio_chip *chip, unsigned offset,
- int value)
-{
- /* This only drives GPOs, and can't change direction */
- return 0;
-}
-
static int twl6040gpo_set(struct gpio_chip *chip, unsigned int offset,
int value)
{
@@ -63,6 +56,13 @@ static int twl6040gpo_set(struct gpio_chip *chip, unsigned int offset,
return twl6040_reg_write(twl6040, TWL6040_REG_GPOCTL, gpoctl);
}
+static int twl6040gpo_direction_out(struct gpio_chip *chip, unsigned int offset,
+ int value)
+{
+ /* This only drives GPOs, and can't change direction */
+ return twl6040gpo_set(chip, offset, value);
+}
+
static struct gpio_chip twl6040gpo_chip = {
.label = "twl6040",
.owner = THIS_MODULE,
--
2.48.1
More information about the linux-arm-kernel
mailing list