[PATCH v5 10/13] arm64: debug: split hardware watchpoint exception entry

[Ada Couprie Diaz]

Hi Catalin, Will

On 07/07/2025 01:46, Catalin Marinas wrote:
> On Fri, Jul 04, 2025 at 06:32:19PM +0100, Will Deacon wrote:
>> On Fri, Jun 27, 2025 at 06:20:35PM +0100, Ada Couprie Diaz wrote:
>>> +static void noinstr el1_dbg(struct pt_regs *regs, unsigned long esr)
>>> +{
>>>   	arm64_enter_el1_dbg(regs);
>>>   	if (!cortex_a76_erratum_1463225_debug_handler(regs))
>>>   		do_debug_exception(far, esr, regs);
>> This leads to:
>>
>> Failed to build patch #10: 0d0a8f024a19 arm64: debug: split hardware watchpoint exception entry
>> arch/arm64/kernel/entry-common.c: In function ‘el1_dbg’:
>> arch/arm64/kernel/entry-common.c:572:36: error: ‘far’ undeclared (first use in this function)
>>    572 |                 do_debug_exception(far, esr, regs);
>>        |                                    ^~~
>>
>>
>> Catalin -- do you reckon we should fix this? [...]
> Works for me, no-one pulled this branch and rely on it being stable. If
> Ada sends a fixup, I can fold it into this patch or merge a new series
> altogether if more patches are affected (or you can do it I don't get to
> a reasonable wifi location in the next few days).
>
> Thanks.
>
I'm glad that fixing my mistakes shouldn't be too big of an issue.
Just to be sure I built every patch individually with my test config,
base defconfig and allnoconfig : the last one surfaced another issue
with Patch 11 when building without COMPAT, so I sent a v6 to fix both.

My apologies for the build issues in this series : that's a lesson 
learned for
future ones. I'll be doing a lot more test builds to try to prevent 
repeating
this situation.

Thanks,
Ada