Re: [PATCH v8 02/16] dt-bindings: net: mediatek,net: allow up to 8 IRQs

[Frank Wunderlich]

Am 7. Juli 2025 08:31:11 MESZ schrieb Krzysztof Kozlowski <krzk at kernel.org>:
>On Sun, Jul 06, 2025 at 03:21:57PM +0200, Frank Wunderlich wrote:
>> From: Frank Wunderlich <frank-w at public-files.de>
>> 
>> Increase the maximum IRQ count to 8 (4 FE + 4 RSS/LRO).
>
>Because? Hardware was updated? It was missing before?

There is no RSS support in driver yet,so IRQs were not added to existing DTS yet.

>> 
>> Frame-engine-IRQs (max 4):
>> MT7621, MT7628: 1 IRQ
>> MT7622, MT7623: 3 IRQs (only two used by the driver for now)
>> MT7981, MT7986, MT7988: 4 IRQs (only two used by the driver for now)
>
>You updated commit msg - looks fine - but same problem as before in your
>code. Now MT7981 has 4-8 interrupts, even though you say here it has only
>4.

Ethernet works with 4,but can be 8 for MT798x.
I cannot increase the MinItems here as it will
throw error because currently only 4 are defined in DTS.same for MT7986.
>> 
>> Mediatek Filogic SoCs (mt798x) have 4 additional IRQs for RSS and/or
>> LRO.
>
>Although I don't know how to treat this. Just say how many interrupts
>are there (MT7981, MT7986, MT7988: 4 FE and 4 RSS), not 4 but later
>actually 4+4.

First block is for Frame Engine IRQs and second for RSS/LRO. Only mention total count 
across all SoCs is imho more confusing.

>I also do not understand why 7 interrupts is now valid... Are these not
>connected physically?

7 does not make sense but i know no way to allow 8 with min 4 without between (5-7).

>Best regards,
>Krzysztof

Hi

Thanks for taking time for review again.

First block are the frame engine IRQs which are max 4 and on all SoCs.
The RSS IRQs are only valid on Filogic (MT798x),so there a total of 8, but on
MT7981 and MT7986 not yet added as i prepare the RSS/LRO driver in background.
We just want to add the IRQs for MT7988 now.
regards Frank