[PATCH v2 1/4] dt-bindings: media: add i.MX parallel csi support

[Krzysztof Kozlowski]

On Thu, Jul 03, 2025 at 02:33:06PM -0400, Frank Li wrote:
> +properties:
> +  compatible:
> +    oneOf:
> +      - const: fsl,imx8qxp-pcif
> +      - items:
> +          - enum:
> +              - fsl,imx91-pcif
> +          - const: fsl,imx93-pcif
> +      - const: fsl,imx93-pcif

This one should be an enum with imx8qxp.


> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 2
> +
> +  clock-names:
> +    items:
> +      - const: pixel
> +      - const: ipg
> +
> +  power-domains:
> +    maxItems: 1
> +
> +  ports:
> +    $ref: /schemas/graph.yaml#/properties/ports
> +
> +    properties:
> +      port at 0:
> +        $ref: /schemas/graph.yaml#/$defs/port-base

Use the properties/port schema instead, you do not have any properties
here (although then question - don't you need anything from video
interfaces?)

> +        unevaluatedProperties: false
> +        description:
> +          Input port node.
> +
> +      port at 1:
> +        $ref: /schemas/graph.yaml#/$defs/port-base

Same here

> +        unevaluatedProperties: false
> +        description:
> +          Output port node.
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - power-domains
> +  - ports
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/imx93-clock.h>
> +    #include <dt-bindings/power/fsl,imx93-power.h>
> +
> +    pcif at 4ac10070 {

That's a CPI bus from MIPI so cpi@, no?

Best regards,
Krzysztof