[PATCH] dt-bindings: arm: sunxi: Combine board variants into enums
Krzysztof Kozlowski
krzysztof.kozlowski at linaro.org
Sun Jul 6 22:31:44 PDT 2025
On 06/07/2025 15:17, Chen-Yu Tsai wrote:
> On Sun, Jul 6, 2025 at 5:58 PM Krzysztof Kozlowski
> <krzysztof.kozlowski at linaro.org> wrote:
>>
>> The common style in all bindings for enumerating similar variants is to
>> use 'enum', not 'oneOf', so all boards of same variant or using same SoM
>> should be grouped under enum. It is more readable, more compact and
>> makes easier to find actual devices from the same family/type. Also
>> there is completely no point to repeat the compatible in the description
>> (incircuit,icnova-a20-adb4006 implies this is "ICnova A20 ADB4006" and
>> pine64,pinephone-1.2 implies "Pine64 PinePhone (1.2)").
>>
>> Combine two easily visible cases: ICnova A20 and Pine64 PinePhone.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
>
> Reviewed-by: Chen-Yu Tsai <wens at csie.org>
>
> I can take it through the sunxi tree if you prefer. We do have new
> boards coming in this cycle, but I don't think there is any overlap
> in the board binding file.
Please take it via sunxi tree. This belongs to sunxi SoC.
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list