[PATCH RFT net-next 02/10] net: stmmac: Add support for Allwinner A523 GMAC200

Chen-Yu Tsai wens at kernel.org
Sun Jul 6 20:06:55 PDT 2025


On Thu, Jul 3, 2025 at 4:19 PM Andrew Lunn <andrew at lunn.ch> wrote:
>
> > +     if (!of_property_read_u32(node, "allwinner,tx-delay-ps", &val)) {
>
> Please use the standard properties rx-internal-delay-ps and
> tx-internal-delay-ps.

Since they share the same binding, I guess I either need to split the
binding so that the new compatible uses the standard properties, or
introduce them to the existing dwmac-sun8i driver as well?

> Please also ensure that if the property is missing, the default is
> 0ps.

This is already implied in this driver with the initial register value
being zero.

ChenYu



More information about the linux-arm-kernel mailing list