[PATCH RFT net-next 04/10] soc: sunxi: sram: register regmap as syscon

Per Larsson per at palvencia.se
Sat Jul 5 02:45:27 PDT 2025


On Wed, 2 Jul 2025 13:01:04 +0800
Chen-Yu Tsai <wens at csie.org> wrote:

> On Wed, Jul 2, 2025 at 12:58 AM Chen-Yu Tsai <wens at kernel.org> wrote:
> >
> > From: Chen-Yu Tsai <wens at csie.org>
> >
> > Until now, if the system controller had a ethernet controller glue
> > layer control register, a limited access regmap would be registered
> > and tied to the system controller struct device for the ethernet
> > driver to use.

"Until now"? 
Does that description (i.e. something that used to happen, but not
after the patch) really match the change?

- snip -

> > +               ret = of_syscon_register_regmap(dev->of_node,
> > regmap);
> > +               if (IS_ERR(ret))  
> 
> BroderTuck on IRC pointed out that this gives a compiler warning.
> Indeed it is incorrect. It should test `ret` directly.
> 
> ChenYu
> 

Regards
Per Larsson, known as BroderTuck on #linux-sunxi



More information about the linux-arm-kernel mailing list