[PATCH v9 5/9] mailbox: add CIX mailbox driver

[Jassi Brar]

On Fri, Jul 4, 2025 at 11:05 AM Arnd Bergmann <arnd at arndb.de> wrote:
>
> On Mon, Jun 9, 2025, at 05:16, Peter Chen wrote:
> > From: Guomin Chen <Guomin.Chen at cixtech.com>
> >
> > The CIX mailbox controller, used in the Cix SoCs, like sky1.
> > facilitates message transmission between multiple processors
> > within the SoC, such as the AP, PM, audio DSP, SensorHub MCU,
> > and others.
> >
> > Reviewed-by: Peter Chen <peter.chen at cixtech.com>
> > Signed-off-by: Guomin Chen <Guomin.Chen at cixtech.com>
> > Signed-off-by: Gary Yang <gary.yang at cixtech.com>
> > Signed-off-by: Lihua Liu <Lihua.Liu at cixtech.com>
> > Signed-off-by: Peter Chen <peter.chen at cixtech.com>
>
> This is the only driver holding up the merge of the CIX
> platform, so I had a closer look myself.
>
Sorry I wasn't made aware of this. Also I normally let the drivers
roast until second half
hoping other platform folks find issues - I have reduced imposing my
opinions on platform
specific code because it is usually met with some sledge-hammer requirement.

>
> The one thing that stuck out to me is the design of
> having multiple types of mailbox in one driver, which
> feels out of scope for a simple mailbox.
>
Yes, if not all modes are used currently, maybe drop unused ones.

I will review the rest separately.

Thanks.