[PATCH v5 2/4] net: stmmac: dwc-qos: Add FSD EQoS support

[Swathi K S]

> -----Original Message-----
> From: Russell King (Oracle) <linux at armlinux.org.uk>
> Sent: 28 January 2025 20:30
> To: Swathi K S <swathi.ks at samsung.com>
> Cc: krzk at kernel.org; robh at kernel.org; davem at davemloft.net;
> edumazet at google.com; kuba at kernel.org; pabeni at redhat.com;
> conor+dt at kernel.org; richardcochran at gmail.com;
> mcoquelin.stm32 at gmail.com; andrew at lunn.ch; alim.akhtar at samsung.com;
> linux-fsd at tesla.com; netdev at vger.kernel.org; devicetree at vger.kernel.org;
> linux-kernel at vger.kernel.org; linux-stm32 at st-md-mailman.stormreply.com;
> linux-arm-kernel at lists.infradead.org; linux-samsung-soc at vger.kernel.org;
> alexandre.torgue at foss.st.com; peppe.cavallaro at st.com;
> joabreu at synopsys.com; rcsekar at samsung.com; ssiddha at tesla.com;
> jayati.sahu at samsung.com; pankaj.dubey at samsung.com;
> ravi.patel at samsung.com; gost.dev at samsung.com
> Subject: Re: [PATCH v5 2/4] net: stmmac: dwc-qos: Add FSD EQoS support
> 
> On Tue, Jan 28, 2025 at 03:55:56PM +0530, Swathi K S wrote:
> > +struct fsd_eqos_plat_data {
> > +	struct clk_bulk_data *clks;
> > +	int num_clks;
> > +	struct device *dev;
> 
> You only write to this, so it serves no purpose in this patch. Please
remove.

Hi Russell, 
Thanks for reviewing.
Will remove  struct device *dev from struct fsd_eqos_plat_data

-Swathi

> 
> Thanks.
> 
> --
> RMK's Patch system: https://protect2.fireeye.com/v1/url?k=8378c0b8-
> e2f3d582-83794bf7-74fe4860008a-3788c416dc857e61&q=1&e=4d22ed29-
> 449b-46e6-90ba-
> 9b1470e01ecb&u=https%3A%2F%2Fwww.armlinux.org.uk%2Fdeveloper%2F
> patches%2F
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!