[PATCH resubmit] spi: atmel-quadspi: remove references to runtime PM on error path
Bence Csókás
csokas.bence at prolan.hu
Mon Jan 27 01:42:58 PST 2025
From: Claudiu Beznea <claudiu.beznea at microchip.com>
There is no need to call runtime PM put APIs on error path of
`atmel_qspi_sama7g5_transfer()` as the caller (`atmel_qspi_exec_op()`)
of it will take care of this if needed.
Fixes: 5af42209a4d2 ("spi: atmel-quadspi: Add support for sama7g5 QSPI")
Signed-off-by: Claudiu Beznea <claudiu.beznea at microchip.com>
Signed-off-by: Durai Manickam KR <durai.manickamkr at microchip.com>
Reported-by: Alexander Dahl <ada at thorsis.com>
Closes: https://lore.kernel.org/linux-spi/20250109-carat-festivity-5f088e1add3c@thorsis.com/
[ csokas.bence: Rebase and clarify msg, fix/add tags ]
Signed-off-by: Bence Csókás <csokas.bence at prolan.hu>
---
Notes:
Rebased onto current spi-next:
commit ff9e24437b18 ("Merge remote-tracking branch 'spi/for-6.13' into spi-linus")
drivers/spi/atmel-quadspi.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c
index abdc49d9d940..e2235d71c822 100644
--- a/drivers/spi/atmel-quadspi.c
+++ b/drivers/spi/atmel-quadspi.c
@@ -930,11 +930,8 @@ static int atmel_qspi_sama7g5_transfer(struct spi_mem *mem,
/* Release the chip-select. */
ret = atmel_qspi_reg_sync(aq);
- if (ret) {
- pm_runtime_mark_last_busy(&aq->pdev->dev);
- pm_runtime_put_autosuspend(&aq->pdev->dev);
+ if (ret)
return ret;
- }
atmel_qspi_write(QSPI_CR_LASTXFER, aq, QSPI_CR);
return atmel_qspi_wait_for_completion(aq, QSPI_SR_CSRA);
--
2.48.1
More information about the linux-arm-kernel
mailing list