[PATCH 1/5] arm64: dts: renesas: r8a779f0: Add labels for rswitch ports

Geert Uytterhoeven geert at linux-m68k.org
Thu Jan 23 08:30:45 PST 2025


Hi Marek,

On Thu, Jan 23, 2025 at 5:20 PM Marek Vasut <marek.vasut at mailbox.org> wrote:
> On 1/23/25 4:25 PM, Geert Uytterhoeven wrote:
> > On Sat, Jan 18, 2025 at 12:14 PM Marek Vasut
> > <marek.vasut+renesas at mailbox.org> wrote:
> >> Introduce labels for each rswitch port in the form 'rswitchportN'.
> >> Those can be used to access rswitch port nodes directly, which is
> >> going to be useful in reducing DT indentation slightly as well as
> >> in DT /aliases node to reference the rswitch ports as ethernetN
> >> interfaces. No functional change.
> >>
> >> Signed-off-by: Marek Vasut <marek.vasut+renesas at mailbox.org>
> >
> > Thanks for your patch!
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas at glider.be>
> > i.e. will queue in renesas-devel for v6.15.
> >
> >> --- a/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
> >> +++ b/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
> >> @@ -974,15 +974,15 @@ ethernet-ports {
> >>                                  #address-cells = <1>;
> >>                                  #size-cells = <0>;
> >>
> >> -                               port at 0 {
> >> +                               rswitchport0: port at 0 {
> >>                                          reg = <0>;
> >>                                          phys = <&eth_serdes 0>;
> >>                                  };
> >> -                               port at 1 {
> >> +                               rswitchport1: port at 1 {
> >>                                          reg = <1>;
> >>                                          phys = <&eth_serdes 1>;
> >>                                  };
> >> -                               port at 2 {
> >> +                               rswitchport2: port at 2 {
> >>                                          reg = <2>;
> >>                                          phys = <&eth_serdes 2>;
> >>                                  };
> >
> > Would you mind if I would change all rswitchportN to rswitch_portN
> > while applying, for consistency with other Renesas DTS files?
>
> Go ahead, but also keep the commit messages in sync .

Sure ;-)

> I can send a V2 too ?

No need for that, as I already made these changes locally.
Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



More information about the linux-arm-kernel mailing list