[PATCH v3 2/4] net: stmmac: dwmac-qcom-ethqos: Mask PHY mode if configured with rgmii-id

Yijie Yang quic_yijiyang at quicinc.com
Wed Jan 22 02:04:38 PST 2025



On 2025-01-22 01:10, Andrew Lunn wrote:
>> To address the ABI compatibility issue between the kernel and DTS caused by
>> this change, handle the compatible string 'qcom,qcs404-evb-4000' in the
>> code, as it is the only legacy board that mistakenly uses the 'rgmii'
>> phy-mode.
> 
> Are you saying every other board DT got this correct? How do you know
> that? Was this SoC never shipped to anybody, so the only possible
> board is the QCOM RDK which never left the lab?
> 
> I doubt this is true, so you are probably breaking out of tree
> boards. We care less about out of tree boards, but we also don't
> needlessly break them.

You're right. My conclusion was based solely on browsing all RGMII-type 
Qualcomm boards under the source tree, and I didn't take the scenario 
you mentioned into account. I will work on coming up with a new 
solution. If you have any suggestions, I will gladly take them as a 
reference.

> 
> 	Andrew

-- 
Best Regards,
Yijie




More information about the linux-arm-kernel mailing list