[PATCH] i2c: iproc: Remove redundant error checks for bcm_iproc_i2c_init

[Uwe Kleine-König]

On Mon, Jan 20, 2025 at 05:03:34PM +0800, Wentao Liang wrote:
> The bcm_iproc_i2c_init() always returns 0. As a result, there
> is no need to check its return value or handle errors.
> 
> This change removes the redundant error handling code after
> calls to bcm_iproc_i2c_init() in both the bcm_iproc_i2c_probe()
> and bcm_iproc_i2c_resume().
> 
> Fixes: e6e5dd3566e0 ("i2c: iproc: Add Broadcom iProc I2C Driver")
> Fixes: 0ee04e91eacd ("i2c: iproc: Add suspend/resume support")

I would drop the Fixes lines.

> Signed-off-by: Wentao Liang <vulab at iscas.ac.cn>
> ---
>  drivers/i2c/busses/i2c-bcm-iproc.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c
> index 15b632a146e1..c683715093d7 100644
> --- a/drivers/i2c/busses/i2c-bcm-iproc.c
> +++ b/drivers/i2c/busses/i2c-bcm-iproc.c
> @@ -1081,9 +1081,7 @@ static int bcm_iproc_i2c_probe(struct platform_device *pdev)
>  		bcm_iproc_algo.unreg_slave = NULL;
>  	}
>  
> -	ret = bcm_iproc_i2c_init(iproc_i2c);
> -	if (ret)
> -		return ret;
> +	bcm_iproc_i2c_init(iproc_i2c);

If you change the prototype to also "return" void, that looks good.

Best regards
Uwe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20250120/765cc49b/attachment.sig>