[PATCH v3 4/5] arm64: dts: amlogic: a4: add pinctrl node
Xianwei Zhao
xianwei.zhao at amlogic.com
Sun Jan 19 22:00:07 PST 2025
Hi Krzysztof,
Thanks for your reply.
On 2025/1/17 16:41, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
>
> On Wed, Jan 15, 2025 at 02:42:02PM +0800, Xianwei Zhao wrote:
>> Add pinctrl device to support Amlogic A4 and add uart pinconf.
>>
>> Signed-off-by: Xianwei Zhao <xianwei.zhao at amlogic.com>
>> ---
>> arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi | 133 ++++++++++++++++++++++++++++
>> 1 file changed, 133 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
>> index de10e7aebf21..8eb95580d64a 100644
>> --- a/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
>> @@ -5,6 +5,7 @@
>>
>> #include "amlogic-a4-common.dtsi"
>> #include <dt-bindings/power/amlogic,a4-pwrc.h>
>> +#include <dt-bindings/pinctrl/amlogic,pinctrl.h>
>> / {
>> cpus {
>> #address-cells = <2>;
>> @@ -48,3 +49,135 @@ pwrc: power-controller {
>> };
>> };
>> };
>> +
>> +&apb {
>> + periphs_pinctrl: pinctrl {
>> + compatible = "amlogic,pinctrl-a4";
>> + #address-cells = <2>;
>> + #size-cells = <2>;
>> + ranges;
>> +
>> + gpiox: gpio at 4100 {
>> + reg = <0 0x4100 0 0x40>,
>> + <0 0x400c 0 0xc>;
>
> One line
>
Will do.
>> + reg-names = "gpio", "mux";
>> + gpio-controller;
>> + #gpio-cells = <2>;
>> + bank-number = <AMLOGIC_GPIO_X>;
>> + gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_X<<8) 18>;
>> + };
>> +
>> + gpiot: gpio at 4140 {
>> + reg = <0 0x4140 0 0x40>,
>> + <0 0x402c 0 0xc>;
>> + reg-names = "gpio", "mux";
>> + gpio-controller;
>> + #gpio-cells = <2>;
>> + bank-number = <AMLOGIC_GPIO_T>;
>> + gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_T<<8) 23>;
>> + };
>> +
>> + gpiod: gpio at 4180 {
>> + reg = <0 0x4180 0 0x40>,
>> + <0 0x4040 0 0x8>;
>> + reg-names = "gpio", "mux";
>> + gpio-controller;
>> + #gpio-cells = <2>;
>> + bank-number = <AMLOGIC_GPIO_D>;
>> + gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_D<<8) 16>;
>> + };
>> +
>> + gpioe: gpio at 41c0 {
>> + reg = <0 0x41c0 0 0x40>,
>> + <0 0x4048 0 0x4>;
>> + reg-names = "gpio", "mux";
>> + gpio-controller;
>> + #gpio-cells = <2>;
>> + bank-number = <AMLOGIC_GPIO_E>;
>> + gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_E<<8) 2>;
>> + };
>> +
>> + gpiob: gpio at 4240 {
>> + reg = <0 0x4240 0 0x40>,
>> + <0 0x4000 0 0x8>;
>> + reg-names = "gpio", "mux";
>> + gpio-controller;
>> + #gpio-cells = <2>;
>> + bank-number = <AMLOGIC_GPIO_B>;
>> + gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_B<<8) 14>;
>> + };
>> +
>> + gpioao: gpio at 8e704 {
>> + reg = <0 0x8e704 0 0x16>,
>> + <0 0x8e700 0 0x4>;
>> + reg-names = "gpio", "mux";
>> + gpio-controller;
>> + #gpio-cells = <2>;
>> + bank-number = <AMLOGIC_GPIO_AO>;
>> + gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_AO<<8) 7>;
>> + };
>> +
>> + test_n: gpio at 8e744 {
>> + reg = <0 0x8e744 0 0x20>;
>> + reg-names = "gpio";
>> + gpio-controller;
>> + #gpio-cells = <2>;
>> + bank-number = <AMLOGIC_GPIO_TEST_N>;
>> + gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_TEST_N<<8) 1>;
>> + };
>> +
>> + func-uart-a {
>> + uart_a_default: group-uart-a-pins1 {
>> + pinmux= <AML_PINMUX(AMLOGIC_GPIO_X, 11, 1)>,
>
> Missing space before '='. Follow DTS coding style.
>
Will fix.
> Best regards,
> Krzysztof
>
More information about the linux-arm-kernel
mailing list