[PATCH] gnss: mtk: Simplify return variables in mtk_set_active and mtk_set_standby
Johan Hovold
johan at kernel.org
Tue Jan 14 07:10:00 PST 2025
On Sun, Nov 17, 2024 at 02:25:01PM +0900, Nobuhiro Iwamatsu wrote:
> Simply return directly instead of assign the return value.
>
> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu at nigauri.org>
> ---
> drivers/gnss/mtk.c | 14 ++------------
> 1 file changed, 2 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gnss/mtk.c b/drivers/gnss/mtk.c
> index c62b1211f4fe4e..be20f6d6470736 100644
> --- a/drivers/gnss/mtk.c
> +++ b/drivers/gnss/mtk.c
> @@ -24,25 +24,15 @@ struct mtk_data {
> static int mtk_set_active(struct gnss_serial *gserial)
> {
> struct mtk_data *data = gnss_serial_get_drvdata(gserial);
> - int ret;
>
> - ret = regulator_enable(data->vcc);
> - if (ret)
> - return ret;
> -
> - return 0;
> + return regulator_enable(data->vcc);
The current style with separate success and error paths was used on
purpose (e.g. to make it obvious from just looking at this function to
determine what is returned).
Johan
More information about the linux-arm-kernel
mailing list