[PATCHv3 1/2] dt-bindings: mfd: syscon: Add ti,j721e-acspcie-proxy-ctrl compatible

[Nishanth Menon]

On 15:07-20241205, Kevin Hilman wrote:
> 
> On Mon, 02 Dec 2024 15:33:30 +0100, Romain Naour wrote:
> > The ACSPCIE_PROXY_CTRL registers within the CTRL_MMR space of TI's J721e
> > SoC are used to drive the reference clock to the PCIe Endpoint device via
> > the PAD IO Buffers. Add the compatible for allowing the PCIe driver to
> > obtain the regmap for the ACSPCIE_CTRL register within the System
> > Controller device-tree node in order to enable the PAD IO Buffers.
> > 
> > The Technical Reference Manual for J721e SoC with details of the
> > ASCPCIE_CTRL registers is available at:
> > https://www.ti.com/lit/zip/spruil1
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/2] dt-bindings: mfd: syscon: Add ti,j721e-acspcie-proxy-ctrl compatible
>       commit: d8efc0b428856137608ffcbb6994da6041c9fe2a
> [2/2] arm64: dts: ti: k3-j721e-beagleboneai64: Enable ACSPCIE output for PCIe1
>       commit: 1d5e14a20dc60b440c60bec8489acfd45cdf7508
> 
> Best regards,
> -- 
> Kevin Hilman <khilman at baylibre.com>
> 
This will need a bit of fixup - See along the lines of the following.
Additionally, we should be a bit careful about the dependency of dts
mix up from two trees.

https://lore.kernel.org/all/20250103174524.28768-1-afd@ti.com/T/#m15dcfa786fc430d54cf96475afc10648372f8589

>From Andrew Davis:

diff --git a/Documentation/devicetree/bindings/soc/ti/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/soc/ti/ti,j721e-system-controller.yaml
index 378e9cc5fac2a..3323f3bc976e0 100644
--- a/Documentation/devicetree/bindings/soc/ti/ti,j721e-system-controller.yaml
+++ b/Documentation/devicetree/bindings/soc/ti/ti,j721e-system-controller.yaml
@@ -68,6 +68,12 @@ patternProperties:
     description:
       The node corresponding to SoC chip identification.
 
+  "^aspcie-ctrl@[0-9a-f]+$":
+    type: object
+    $ref: /schemas/mfd/syscon.yaml#
+    description:
+      This is the ASPCIe control region.
+
 required:
   - compatible
   - reg
@@ -110,5 +116,10 @@ examples:
             compatible = "ti,am654-chipid";
             reg = <0x14 0x4>;
         };
+
+        acspcie0_proxy_ctrl: aspcie-ctrl at 18090 {
+            compatible = "ti,j721e-acspcie-proxy-ctrl", "syscon";
+            reg = <0x18090 0x4>;
+        };
     };
 ...
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
index 32a232a90100e..4b2101e90fb51 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
@@ -84,7 +84,7 @@ ehrpwm_tbclk: clock-controller at 4140 {
                        #clock-cells = <1>;
                };
 
-               acspcie0_proxy_ctrl: syscon at 18090 {
+               acspcie0_proxy_ctrl: aspcie-ctrl at 18090 {
                        compatible = "ti,j721e-acspcie-proxy-ctrl", "syscon";
                        reg = <0x18090 0x4>;
                };

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D