[PATCH v2 2/4] dt-bindings: power: supply: add max77759-fg flavor
Thomas Antoine
t.antoine at uclouvain.be
Fri Jan 3 08:16:03 PST 2025
On 1/2/25 17:08, Krzysztof Kozlowski wrote:
> On 02/01/2025 12:15, Thomas Antoine via B4 Relay wrote:
>> From: Thomas Antoine <t.antoine at uclouvain.be>
>>
>> The max77759 is an IC used to manage the power supply of the battery and
>
> Still not the name I asked to use.
Indeed, I missed that, I will fix this.
[...]
>> -allOf:
>> - - $ref: power-supply.yaml#
>> -
>> properties:
>> compatible:
>> oneOf:
>> - const: maxim,max17201
>> + - const: maxim,max77759-fg
>> - items:
>> - enum:
>> - maxim,max17205
>> - const: maxim,max17201
>>
>> - reg:
>> - items:
>> - - description: ModelGauge m5 registers
>> - - description: Nonvolatile registers
>
> Widest constraints always stay here.
>
> See:
> https://elixir.bootlin.com/linux/v6.11-rc6/source/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml#L127
>
> I did not say to remove it. I asked you to add allOf section restricting it.
Thanks for the example. I think I understand now. I will put the reg section
back and use min/maxItems in the allOf:if: to set the number of reg/reg-names
to 1 for the MAX77759.
Do I keep shunt-resistor-micro-ohms as I did it here? I could move it in
properties: and only make it required by the max77759 in the allOf:if:. However,
I think this would make it seem as if the MAX17201 optionally accepts it when
it would do nothing in practice so I'm not sure what is the best choice.
>> -
>> - reg-names:
>> - items:
>> - - const: m5
>> - - const: nvmem
>> -
>> interrupts:
>> maxItems: 1
>>
>> +allOf:
>
> This goes after required: block. See example-schema.
>
>> + - $ref: power-supply.yaml#
>> + - if:
> Best regards,
> Krzysztof
Will fix.
Best regards,
Thomas
More information about the linux-arm-kernel
mailing list