[PATCH v2] arm64: dts: ti: k3-am69-sk: Add USB SuperSpeed support
Siddharth Vadapalli
s-vadapalli at ti.com
Thu Jan 2 06:05:44 PST 2025
On Thu, Jan 02, 2025 at 07:23:10PM +0530, Siddharth Vadapalli wrote:
> On Wed, Dec 04, 2024 at 12:05:26PM +0100, Enric Balletbo i Serra wrote:
> > From: Dasnavis Sabiya <sabiya.d at ti.com>
> >
> > AM69 SK board has two stacked USB3 connectors:
> > 1. USB3 (Stacked TypeA + TypeC)
> > 2. USB3 TypeA Hub interfaced through TUSB8041.
> >
> > The board uses SERDES0 Lane 3 for USB3 IP. So update the
> > SerDes lane info for PCIe and USB. Add the pin mux data
>
> nitpick: s/SerDes/SERDES to keep it consistent with the convention
> followed at all other places.
>
> > and enable USB 3.0 support with its respective SERDES settings.
> >
> > Signed-off-by: Dasnavis Sabiya <sabiya.d at ti.com>
> > Signed-off-by: Enric Balletbo i Serra <eballetb at redhat.com>
>
> Reviewed-by: Siddharth Vadapalli <s-vadapalli at ti.com>
I failed to notice it, but Roger's comment on the v1 patch at:
https://lore.kernel.org/all/5af2e2fa-3f60-419e-be3e-74771a993de6@kernel.org/
hasn't been addressed in this patch.
J784S4_IOPAD(0x0EC, PIN_OUTPUT, 6) /* (AN37) TIMER_IO1.USB0_DRVVBUS */
should be
J784S4_IOPAD(0x0ec, PIN_OUTPUT, 6) /* (AN37) TIMER_IO1.USB0_DRVVBUS */
Please fix this.
Regards,
Siddharth.
More information about the linux-arm-kernel
mailing list