[PATCH v4 3/5] pinctrl: Add driver support for Amlogic SoCs
Xianwei Zhao
xianwei.zhao at amlogic.com
Thu Feb 6 23:07:27 PST 2025
Hi Linus,
Thanks for your reply.
On 2025/1/27 17:59, Linus Walleij wrote:
> [ EXTERNAL EMAIL ]
>
> Hi Xianwei,
>
> thanks for your patch!
>
> On Wed, Jan 22, 2025 at 4:26 AM Xianwei Zhao via B4 Relay
> <devnull+xianwei.zhao.amlogic.com at kernel.org> wrote:
>
>> From: Xianwei Zhao <xianwei.zhao at amlogic.com>
>>
>> Add a new pinctrl driver for Amlogic SoCs. All future Amlogic
>> SoCs pinctrl drives use this, such A4, A5, S6, S7 etc. To support
>> new Amlogic SoCs, only need to add the corresponding dts file.
>>
>> Signed-off-by: Xianwei Zhao <xianwei.zhao at amlogic.com>
>> ---
>> drivers/pinctrl/Kconfig | 18 +
>> drivers/pinctrl/Makefile | 1 +
>> drivers/pinctrl/pinctrl-amlogic.c | 1053 +++++++++++++++++++++++++++++++++++++
>
> Please move this file into drivers/pinctrl/meson as I requested
> earlier. We can rename "meson" to "amlogic" later if that placement
> is confusing.
>
Will Move this file into drivers/pinctrl/meson in next version.
>> +config PINCTRL_AMLOGIC
>
> There is already PINCTRL_AMLOGIC_C3 and PINCTRL_AMLOGIC_T7
> as will be very apparent when you move this driver.
>
> What is a *proper* name for this family of SoCs?
>
This is for A4, Will use PINCTRL_AMLOGIC_A4 instead.
>> +MODULE_LICENSE("Dual BSD/GPL");
>
> On the top of the file you have:
>> +// SPDX-License-Identifier: GPL-2.0-only
>
> So this does not add up. Fix one or the other.
>
Will drop "MODULE_LICENSE("Dual BSD/GPL");".
> Yours,
> Linus Walleij
More information about the linux-arm-kernel
mailing list