[PATCH net-next 3/3] net: dsa: mt7530: convert to phylink managed EEE
Russell King (Oracle)
linux at armlinux.org.uk
Thu Feb 6 07:58:17 PST 2025
On Wed, Feb 05, 2025 at 03:42:30PM +0000, Chester A. Unal wrote:
> Hello Russell.
>
> On 05/02/2025 15:11, Russell King (Oracle) wrote:
> > Fixme: doesn't bit 25 and 26 also need to be set in the PMCR for
> > PMCR_FORCE_EEE100 and PMCR_FORCE_EEE1G to take effect?
>
> Yes, but only for MT7531 and the switch component of the MT7988 SoC. For
> MT7530 and the switch component of the AN7581 SoC, bit 15
> (MT7530_FORCE_MODE) must be set. The MT753X DSA subdriver sets these bits
> accordingly at the setup function that pertains to the specific switch
> model.
I'll remove the comment in the commit message. I also note from
patchwork that I need to remove lpi_timer_limit_us... so v2 will be
posted in the next day or so.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
More information about the linux-arm-kernel
mailing list