[PATCH v2] net: ethernet: actions: Use of_get_available_child_by_name()

Biju Das biju.das.jz at bp.renesas.com
Sun Feb 2 02:16:46 PST 2025


Hi Andrew,

> -----Original Message-----
> From: Andrew Lunn <andrew at lunn.ch>
> Sent: 01 February 2025 18:55
> To: Biju Das <biju.das.jz at bp.renesas.com>
> Cc: Andrew Lunn <andrew+netdev at lunn.ch>; David S. Miller <davem at davemloft.net>; Eric Dumazet
> <edumazet at google.com>; Jakub Kicinski <kuba at kernel.org>; Paolo Abeni <pabeni at redhat.com>; Andreas
> Färber <afaerber at suse.de>; Manivannan Sadhasivam <manivannan.sadhasivam at linaro.org>;
> netdev at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-actions at lists.infradead.org; Geert
> Uytterhoeven <geert+renesas at glider.be>; biju.das.au <biju.das.au at gmail.com>
> Subject: Re: [PATCH v2] net: ethernet: actions: Use of_get_available_child_by_name()
> 
> On Sat, Feb 01, 2025 at 05:27:40PM +0000, Biju Das wrote:
> > Use the helper of_get_available_child_by_name() to simplify
> > owl_emac_mdio_init().
> >
> > Signed-off-by: Biju Das <biju.das.jz at bp.renesas.com>
> > ---
> > v1->v3:
> >  * Dropped duplicate mdio_node declaration.
> 
> And version 2?

It is typo. Actually it is v1->v2:

> 
> https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
> 
> Also
> 
> 1.6.7. Resending after review
> 
> Allow at least 24 hours to pass between postings. This will ensure reviewers from all geographical
> locations have a chance to chime in.
> 

Sorry for that.

> and section
> 
> 1.6.6. Clean-up patches
> 
> Netdev discourages patches which perform simple clean-ups, which are not in the context of other work.
> For example:
> 
> o Addressing checkpatch.pl warnings
> o Addressing Local variable ordering issues o Conversions to device-managed APIs (devm_ helpers)
> 
> This is because it is felt that the churn that such changes produce comes at a greater cost than the
> value of such clean-ups.

OK, Will send next version with simpler readable code, once
dependency patch hits on net-next.

Cheers,
Biju



More information about the linux-arm-kernel mailing list