[PATCH v3 13/13] arm64: defconfig: Enable Renesas RZ/T2H SoC option
Krzysztof Kozlowski
krzk at kernel.org
Thu Feb 27 05:34:32 PST 2025
On 27/02/2025 14:25, Geert Uytterhoeven wrote:
> Hi Krzysztof,
>
> On Thu, 27 Feb 2025 at 12:48, Krzysztof Kozlowski <krzk at kernel.org> wrote:
>> On 27/02/2025 11:48, Thierry Bultel wrote:
>>>> This is fine, I am not against fine-grained SoC-enable options. However
>>>> all your SoCs should be enabled by default (default y if ARCH_RENESAS or
>>>> any other option which works for you) thus you won't be growing user-
>>>> selectable choices.
>>>>
>>>> Strictly speaking this still will be choice, because you need to trim
>>>> config, but all people and all distros will just ignore it and don't see
>>>> it in defconfig.
>>>>
>>>
>>> I understand.
>>>
>>> All the ARCH_XXX SoC options are already under a menuconfig section, which
>>> is defaulted to 'y' if ARCH_RENESAS.
>>
>> Indeed and it actually cannot have "if ARCH_RENESAS" due to how compile
>> test is enabled there.
>
> Sorry, I don't get what you mean here...
Probably I got top-level COMPILE_TEST opposite and it actually should be
"if ARCH_RENESAS" as I suggested. Otherwise it would be enabled by
default for compile tests.
>
>>> So I guess that this simple additional change would make it:
>>>
>>> diff --git a/drivers/soc/renesas/Kconfig b/drivers/soc/renesas/Kconfig
>>> index 91a815e0a522..231880c21aa7 100644
>>> --- a/drivers/soc/renesas/Kconfig
>>> +++ b/drivers/soc/renesas/Kconfig
>>> @@ -358,6 +358,7 @@ config ARCH_R9A09G057
>>>
>>> config ARCH_R9A09G077
>>> bool "ARM64 Platform support for RZ/T2H"
>>> + default y
>
> Please add "if ARCH_RENESAS" iff we decide to go this route...
Yeah, like I suggested earlier.
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list