[PATCH] media: imx: fix a potential memory leak in imx_media_csc_scaler_device_init()
Dan Carpenter
dan.carpenter at linaro.org
Wed Feb 26 06:41:53 PST 2025
On Wed, Feb 26, 2025 at 10:21:26PM +0800, Haoxiang Li wrote:
> Add video_device_release() in label 'err_m2m' to release the memory
> allocated by video_device_alloc() and prevent potential memory leaks.
>
> Fixes: a8ef0488cc59 ("media: imx: add csc/scaler mem2mem device")
> Cc: stable at vger.kernel.org
> Signed-off-by: Haoxiang Li <haoxiang_li2024 at 163.com>
> ---
> drivers/staging/media/imx/imx-media-csc-scaler.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/media/imx/imx-media-csc-scaler.c b/drivers/staging/media/imx/imx-media-csc-scaler.c
> index e5e08c6f79f2..f99c88e87a94 100644
> --- a/drivers/staging/media/imx/imx-media-csc-scaler.c
> +++ b/drivers/staging/media/imx/imx-media-csc-scaler.c
> @@ -913,6 +913,7 @@ imx_media_csc_scaler_device_init(struct imx_media_dev *md)
>
> err_m2m:
> video_set_drvdata(vfd, NULL);
> + video_device_release(vfd);
The video_set_drvdata() call is pointless. It just does:
vfd.dev->driver_data = NULL;
but that's not necessary if we're just going to free "vfd" on the next
line.
regards,
dan carpenter
> err_vfd:
> kfree(priv);
> return ERR_PTR(ret);
More information about the linux-arm-kernel
mailing list