[PATCH v2 2/4] KVM: arm64: Don't WARN from __pkvm_host_share_guest()

[Marc Zyngier]

On Tue, 25 Feb 2025 19:49:43 +0000,
Quentin Perret <qperret at google.com> wrote:
> 
> On Tuesday 25 Feb 2025 at 18:02:02 (+0000), Marc Zyngier wrote:
> > On Tue, 25 Feb 2025 01:53:25 +0000,
> > Quentin Perret <qperret at google.com> wrote:
> > > 
> > > We currently WARN() if the host attempts to share a page that is not in
> > > an acceptable state with a guest. This isn't strictly necessary and
> > > makes testing much harder, so drop the WARN and fix the error code.
> > 
> > Are you really fixing the error code? You still seem to return a
> > -EPERM. I guess this was never reachable thanks to WARN() being a
> > panic with pKVM?
> 
> Exactly, this is really poor wording in the commit message. 'Fix the
> error code' in this case was intended to mean 'make sure to return the
> error code properly instead outright crashing the device'.
> 
> Happy to send out a v3 with a better commit message.

Nah, that's probably something Oliver can fixup when picking up the
patch.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.