[PATCH 1/5] dt-bindings: arm: Add Coresight device Trace NOC definition

Yuanfang Zhang quic_yuanfang at quicinc.com
Wed Feb 26 02:52:11 PST 2025



On 2/22/2025 6:47 PM, Krzysztof Kozlowski wrote:
> On 21/02/2025 08:40, Yuanfang Zhang wrote:
>> Adds new coresight-tnoc.yaml file describing the bindings required
>> to define Trace NOC in the device trees.
>>
>> Signed-off-by: Yuanfang Zhang <quic_yuanfang at quicinc.com>
> 
> 
> So you just sent the same v1, ignoring previous review. That's not how
> it works.
> 
sorry for this incorrect process. because i just update --to-cc list and no other
change, i forced the version to V1, hoped it would work like resend,
but the result was not as expected.

> Provide proper changelog, implement ENTIRE feedback and do no ask
> maintainers do point the same issues TWICE.
> 
> NAK
> 
> <form letter>
> It seems my or other reviewer's previous comments were not fully
> addressed. Maybe the feedback got lost between the quotes, maybe you
> just forgot to apply it. Please go back to the previous discussion and
> either implement all requested changes or keep discussing them.
> 
> Thank you.
> </form letter>
> 
> Best regards,
> Krzysztof
> 




More information about the linux-arm-kernel mailing list