net: stmmac: weirdness in stmmac_hw_setup()
Thierry Reding
treding at nvidia.com
Tue Feb 25 10:33:18 PST 2025
On Thu, Feb 20, 2025 at 04:17:43PM +0000, Russell King (Oracle) wrote:
> While looking through the stmmac driver, I've come across some
> weirdness in stmmac_hw_setup() which looks completely barmy to me.
>
> It seems that it follows the initialisation suggested by Synopsys
> (as best I can determine from the iMX8MP documentation), even going
> as far as to *enable* transmit and receive *before* the network
> device has been administratively brought up. stmmac_hw_setup() does
> this:
>
> /* Enable the MAC Rx/Tx */
> stmmac_mac_set(priv, priv->ioaddr, true);
>
> which sets the TE and RE bits in the MAC configuration register.
>
> This means that if the network link is active, packets will start
> to be received and will be placed into the receive descriptors.
>
> We won't transmit anything because we won't be placing packets in
> the transmit descriptors to be transmitted.
>
> However, this in stmmac_hw_setup() is just wrong. Can it be deleted
> as per the below?
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index c2913f003fe6..d6e492f523f5 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -3493,9 +3493,6 @@ static int stmmac_hw_setup(struct net_device *dev, bool ptp_register)
> priv->hw->rx_csum = 0;
> }
>
> - /* Enable the MAC Rx/Tx */
> - stmmac_mac_set(priv, priv->ioaddr, true);
> -
> /* Set the HW DMA mode and the COE */
> stmmac_dma_operation_mode(priv);
>
Tested this on Jetson TX2 and couldn't detect a change in behaviour.
Booted the device using NFS and ran a few iterations of iperf. Same
as before, so:
Tested-by: Thierry Reding <treding at nvidia.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20250225/f6b338b5/attachment.sig>
More information about the linux-arm-kernel
mailing list