[PATCH 4/5] arm64: dts: imx8mp: convert 'aips5' to 'aipstz5'

[Frank Li]

On Tue, Feb 25, 2025 at 04:14:34PM +0200, Mihalcea Laurentiu wrote:
>
> On 21.02.2025 21:56, Frank Li wrote:
> > On Fri, Feb 21, 2025 at 02:19:08PM -0500, Laurentiu Mihalcea wrote:
> >> From: Laurentiu Mihalcea <laurentiu.mihalcea at nxp.com>
> >>
> >> AIPS5 is actually AIPSTZ5 as it offers some security-related
> >> configurations. Since these configurations need to be applied before
> >> accessing any of the peripherals on the bus, it's better to make AIPSTZ5
> >> be their parent instead of keeping AIPS5 and adding a child node for
> >> AIPSTZ5. Also, because of the security configurations, the address space
> >> of the bus has to be changed to that of the configuration registers.
> > The orginal 0x30c0_0000..0x31200000 include 0x30df0000, why not map only
> > config address part in your drivers.
> >
> > Frank
>
>
> Any concerns/anything wrong with current approach?
>
>
> I find it a bit awkward to have the whole bus address space
>
> in the DT given that we're only interested in using the access
>
> controller register space.
>
>
> I'm fine with the approach you suggested but I don't see a
>
> reason for using it?

After second through, reg should indicate only used space. The current
method is good enough. Just need figure out KK's comment about 'simple-bus'

Frank

>
>
> >
> >> Finally, since AIPSTZ5 belongs to the AUDIOMIX power domain, add the
> >> missing 'power-domains' property. The domain needs to be powered on before
> >> attempting to configure the security-related registers.
> >>
> >> The DT node name is not changed to avoid potential issues with DTs in
> >> which this node is referenced.
> >>
> >> Co-developed-by: Daniel Baluta <daniel.baluta at nxp.com>
> >> Signed-off-by: Daniel Baluta <daniel.baluta at nxp.com>
> >> Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea at nxp.com>
> >> ---
> >>  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 8 +++++---
> >>  1 file changed, 5 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> >> index e0d3b8cba221..a1d9b834d2da 100644
> >> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> >> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> >> @@ -1399,11 +1399,13 @@ eqos: ethernet at 30bf0000 {
> >>  			};
> >>  		};
> >>
> >> -		aips5: bus at 30c00000 {
> >> -			compatible = "fsl,aips-bus", "simple-bus";
> >> -			reg = <0x30c00000 0x400000>;
> >> +		aips5: bus at 30df0000 {
> >> +			compatible = "fsl,imx8mp-aipstz", "simple-bus";
> >> +			reg = <0x30df0000 0x10000>;
> >> +			power-domains = <&pgc_audio>;
> >>  			#address-cells = <1>;
> >>  			#size-cells = <1>;
> >> +			#access-controller-cells = <0>;
> >>  			ranges;
> >>
> >>  			spba-bus at 30c00000 {
> >> --
> >> 2.34.1
> >>