[PATCH 1/2] ARM: dts: bcm2711: PL011 UARTs are actually r1p5

[Florian Fainelli]

On 2/23/2025 1:17 PM, Stefan Wahren wrote:
> Am 23.02.25 um 17:58 schrieb Florian Fainelli:
>>
>>
>> On 23/02/2025 04:56, Stefan Wahren wrote:
>>> From: Phil Elwell <phil at raspberrypi.com>
>>>
>>> The ARM PL011 UART instances in BCM2711 are r1p5 spec, which means they
>>> have 32-entry FIFOs. The correct periphid value for this is 0x00341011.
>>> Thanks to N Buchwitz for pointing this out.
>>
>> Should not that require warrant a Reported-by here?
> I tried to find the original discussion, but i couldn't find it. Also I
> don't know if this person wants their mail address published.

That seems fair enough.

>>
>>>
>>> Signed-off-by: Phil Elwell <phil at raspberrypi.com>
>>> Signed-off-by: Stefan Wahren <wahrenst at gmx.net>
>>
>> Some people might consider this to be a bug fix, mind adding a Fixes tag?
> tbh, i'm not aware of any (real) negative impact, but yes i'm fine to
> add it.

The negative impact would that you would be more prone to see RX FIFO 
overflows under workloads where interrupts get disabled for too long. We 
have seen some of those happen in our test rack so the larger FIFOs the 
better usually:

https://lore.kernel.org/r/1692643978-16570-1-git-send-email-justin.chen@broadcom.com

I don't mind adding the fixes tag while applying, no need to re-submit. 
Thanks Stefan!
-- 
Florian