[PATCH 4/4] soc: apple: rtkit: Cut syslog messages after the first '\0'
Alyssa Rosenzweig
alyssa at rosenzweig.io
Mon Feb 24 10:10:41 PST 2025
Reviewed-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Le Sat , Feb 22, 2025 at 04:56:49PM +0000, Sven Peter via B4 Relay a écrit :
> From: Janne Grunau <j at jannau.net>
>
> Certain messages from DCP contain NUL bytes in the random data after the
> NUL terminated syslog message. Since the syslog message ends with '\n'
> this results in a dev_info() message terminated with two newlines and an
> empty printed line in the kernel log.
>
> Signed-off-by: Janne Grunau <j at jannau.net>
> Signed-off-by: Sven Peter <sven at svenpeter.dev>
> ---
> drivers/soc/apple/rtkit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/apple/rtkit.c b/drivers/soc/apple/rtkit.c
> index b7f4654c3341..595efce265ce 100644
> --- a/drivers/soc/apple/rtkit.c
> +++ b/drivers/soc/apple/rtkit.c
> @@ -476,7 +476,7 @@ static void apple_rtkit_syslog_rx_log(struct apple_rtkit *rtk, u64 msg)
>
> log_context[sizeof(log_context) - 1] = 0;
>
> - msglen = rtk->syslog_msg_size - 1;
> + msglen = strnlen(rtk->syslog_msg_buffer, rtk->syslog_msg_size - 1);
> while (msglen > 0 &&
> should_crop_syslog_char(rtk->syslog_msg_buffer[msglen - 1]))
> msglen--;
>
> --
> 2.34.1
>
>
More information about the linux-arm-kernel
mailing list