[PATCH 1/4] soc: apple: rtkit: Add APPLE_RTKIT_PWR_STATE_INIT

Alyssa Rosenzweig alyssa at rosenzweig.io
Mon Feb 24 10:03:44 PST 2025


> -	msg = FIELD_PREP(APPLE_RTKIT_MGMT_PWR_STATE, APPLE_RTKIT_PWR_STATE_ON);
> +	msg = FIELD_PREP(APPLE_RTKIT_MGMT_PWR_STATE, APPLE_RTKIT_PWR_STATE_INIT);

Commit message doesn't match the code. Just adding the state doesn't
imply a behaviour change but the patch is one. How about "Use INIT state
instead of ON" or something to make explicit the behaviour change?



More information about the linux-arm-kernel mailing list