[PATCH v5 1/9] dt-bindings: mfd: brcm,bcm59056: Convert to YAML
Artur Weber
aweber.kernel at gmail.com
Sat Feb 22 02:57:37 PST 2025
On 22.02.2025 10:43, Krzysztof Kozlowski wrote:
> On Fri, Feb 21, 2025 at 09:16:23PM +0100, Artur Weber wrote:
>> Convert devicetree bindings for the Broadcom BCM59056 PMU MFD from
>> TXT to YAML format. This patch does not change any functionality;
>> the bindings remain the same.
>>
>> The bindings have been split into two parts: the MFD binding and
>> a separate binding for the regulator node, to simplify the addition
>> of other models later (which have different regulators).
>>
>> Signed-off-by: Artur Weber <aweber.kernel at gmail.com>
>> ---
>> Changes in v5:
>> - Replace mfd/brcm,bcm59056.yaml with mfd/brcm,bcm590xx.yaml in
>> regulator binding description
>>
>> Changes in v4:
>> - Made $ref use full schema path
>> - Cleaned up example
>> - Dropped regulator name list comment
>> - Changed description of regulator binding to mention BCM59056
>> explicitly
>> - Changed "Power Management IC" to "Power Management Unit" to match
>> official Broadcom naming
>> - Renamed mfd/brcm,bcm59056.yaml to mfd/brcm,bcm590xx.yaml
>
> I don't understand why the name became "xx", instead of matching exactly
> compatible. It wasn't like this when I reviewed it last time and this is
> really unexpected change.
>
> Please follow standard rules: filename must match compatible.
The change was mostly to make it more generic; it felt a bit weird that
the BCM59054 regulator binding (added in the next patch) referenced a
binding named after BCM59056. But if this is not a problem, and a
concrete model number is required (even if it is only one of the
supported devices), then I'll switch back to the bcm59056 name.
Best regards
Artur
More information about the linux-arm-kernel
mailing list