[PATCH 1/3] arm64: extable: Add fixup handling for uaccess CPY* instructions

Kristina Martšenko kristina.martsenko at arm.com
Fri Feb 21 11:34:42 PST 2025


On 20/02/2025 18:55, Robin Murphy wrote:
> On 18/02/2025 5:14 pm, Kristina Martšenko wrote:
>>   +static bool cpy_faulted_on_uaccess(const struct exception_table_entry *ex,
>> +                   unsigned long esr)
>> +{
>> +    bool uaccess_is_write = FIELD_GET(EX_DATA_UACCESS_WRITE, ex->data);
>> +    bool fault_on_write = esr & ESR_ELx_WNR;
>> +
>> +    return !(uaccess_is_write ^ fault_on_write);
> 
> Nit: isn't that simply "uaccess_is_write == fault_on_write"?

Yes, that's better.

Thanks,
Kristina




More information about the linux-arm-kernel mailing list