[PATCH net-next v2 1/3] net: ti: icssg-prueth: Use page_pool API for RX buffer allocation

Diogo Ivo diogo.ivo at siemens.com
Tue Feb 18 04:24:59 PST 2025


Hi Meghana,

On 2/18/25 10:10 AM, Malladi, Meghana wrote:
> On 2/12/2025 7:26 PM, Roger Quadros wrote:
>> Can we get rid of SKB entirely from the management channel code?
>> The packet received on this channel is never passed to user space so
>> I don't see why SKB is required.
>>
> 
> Yes I do agree with you on the fact the SKB here is not passed to the 
> network stack, hence this is redundant. But honestly I am not sure how 
> that can be done, because the callers of this function access skb->data
> from the skb which is returned and the same can't be done with page (how 
> to pass the same data using page?)
> Also as you are aware we are not currently supporting SR1 devices 
> anymore, hence I don't have any SR1 devices handy to test these changes 
> and ensure nothing is broken if I remove SKB entirely.

I have some SR1 devices available and would be happy to test these
proposed changes in case they are feasible.

Best regards,
Diogo



More information about the linux-arm-kernel mailing list