[PATCH] arm64: dts: ti: k3-am62a7-sk: Add alias for RTC
Kendall Willis
k-willis at ti.com
Fri Feb 14 14:37:03 PST 2025
On 2/14/25 00:21, Dhruva Gole wrote:
> On Feb 12, 2025 at 15:06:04 -0600, Kendall Willis wrote:
>> From: Vibhore Vardhan <vibhore at ti.com>
>>
>> Adds alias for SoC RTC so that it gets assigned rtc0. PMIC node is
>> assisgned rtc1 so that PMIC RTC gets probed as rtc1. This makes it
>
> Nit: Fix the spelling of assigned please.
>
>> consistent for testing rtcwake with other AM62 devices where rtc0
>> is SoC RTC.
>>
>> Signed-off-by: Vibhore Vardhan <vibhore at ti.com>
>> [k-willis at ti.com: Reworded commit message]
>> Signed-off-by: Kendall Willis <k-willis at ti.com>
>> ---
>> Tested with rtcwake on AM62A.
>
> Any test logs you can provide would be great!
>
>>
>> Original patch for AM62A existed in the TI Vendor tree with Vibhore's
>> authorship:
>> https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/commit/?h=ti-linux-6.6.y&id=f745d9063212d1088dcfb068ecb4b16648b96487
>> ---
>> arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
>> index a6f0d87a50d8..51ea961f166e 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
>> @@ -22,6 +22,8 @@ aliases {
>> serial3 = &main_uart1;
>> mmc0 = &sdhci0;
>> mmc1 = &sdhci1;
>> + rtc0 = &wkup_rtc0;
>> + rtc1 = &tps659312;
>> };
>>
>> chosen {
>>
>> base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
>
> It's nice that you've mentioned this, but it seems to be from Feb2.
> Can you please base it on latest linux-next when you send in future?
> This will avoid any merge conflicts in advance.
>
> For this though, you may get away with it because nobody else may have
> touched this file so far...
>
> If you do send a v2, feel free to pick:
> Reviewed-by: Dhruva Gole <d-gole at ti.com>
>
Hi Dhruva,
Thanks for the feedback and the review. I will be adding the changes
mentioned by you in v2 :)
Best,
Kendall Willis
More information about the linux-arm-kernel
mailing list