[PATCH v2 5/5] ASoC: sun4i-codec: change h616 card name

Ryan Walklin ryan at testtoast.com
Fri Feb 14 12:52:55 PST 2025



On Tue, 28 Jan 2025, at 2:10 PM, Ryan Walklin wrote:
> On Sun, 26 Jan 2025, at 8:51 PM, Icenowy Zheng wrote:
>>> -       card->name              = "H616 Audio Codec";
>>> +       card->name              = "h616-audio-codec";
>>> +       card->long_name         = "H616 Audio Codec";
>>
>> I think it's part of the userspace API that should be kept stable.
>
> I don't have a strong feeling about this change, but can anyone suggest 
> any other options for how to manage this name being picked up by UCM as 
> a file path? I guess the UCM paths can include spaces, but this is 
> slightly unwieldy and may break if proper escaping is not done.

Apologies I have misinterpreted what the user-space code expects, it seems (as per https://github.com/alsa-project/alsa-ucm-conf/blob/master/ucm2/README.md) that the UCM file path is derived from long_name, not name, and name is only used as a fallback if long_name is not provided. Will send a v3 just adding a long_name instead.

Regards,

Ryan



More information about the linux-arm-kernel mailing list