[PATCH] pwm: clps711x: Drop of_match_ptr() usage for .of_match_table
Andy Shevchenko
andriy.shevchenko at linux.intel.com
Fri Feb 14 10:43:18 PST 2025
On Fri, Feb 14, 2025 at 05:34:42PM +0100, Uwe Kleine-König wrote:
> The pwm-clps711x driver depends on ARCH_CLPS711X || COMPILE_TEST. With
> the former being an ARCH_MULTI_V4T platform, there is always OF=y when
> ARCH_CLPS711X=y, so in practise clps711x_pwm_dt_ids[] is always used.
> (And in the case COMPILE_TEST=y + OF=n this only increases the driver
> size a bit but still compiles.)
>
> So drop the usage of of_match_ptr().
FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
Note, that those macros, of_match_ptr() and ACPI_PTR(), more harmful
then helpful. If you look at the history of the project, you may find
many patches that were fixing compilation warnings of unused variables
or so due to (mis)uses of those macros.
--
With Best Regards,
Andy Shevchenko
More information about the linux-arm-kernel
mailing list