[PATCH v6 1/2] dt-bindings: net: Add FSD EQoS device tree bindings

Krzysztof Kozlowski krzk at kernel.org
Fri Feb 14 02:55:49 PST 2025


On 14/02/2025 10:33, Swathi K S wrote:
>>> Could you please help in detail what specifically needs to be modified
>> regarding the ordering and minItems/maxItems usage?
>> You did not try hard enough.
>>
>> Open other bindings and look how they list clocks. For example any Samsung
>> clock controller bindings. Or any qcom bindings.
> 
> Thanks for your insight. I tried understanding the dt-binding implementations from Samsung/ qcom as you suggested.
> I am thinking of making the following modification in clock-names:
> 
> clock-names:
>      minItems: 5
>      items:
>          - const: ptp_ref
>          - const: master_bus
>          - const: slave_bus
>          - const: tx
>          - const: rx
>          - const: master2_bus
>          - const: slave2_bus
>          - const: eqos_rxclk_mux
>          - const: eqos_phyrxclk
>          - const: dout_peric_rgmii_clk
> 		 
> Does this align with your feedback or do you suggest any further changes?

Yes.

Best regards,
Krzysztof



More information about the linux-arm-kernel mailing list