[PATCH v6 1/2] dt-bindings: net: Add FSD EQoS device tree bindings

[Swathi K S]

> -----Original Message-----
> From: Andrew Lunn <andrew at lunn.ch>
> Sent: 14 February 2025 05:50
> To: Swathi K S <swathi.ks at samsung.com>
> Cc: krzk+dt at kernel.org; andrew+netdev at lunn.ch; davem at davemloft.net;
> edumazet at google.com; kuba at kernel.org; pabeni at redhat.com;
> robh at kernel.org; conor+dt at kernel.org; richardcochran at gmail.com;
> mcoquelin.stm32 at gmail.com; alexandre.torgue at foss.st.com;
> rmk+kernel at armlinux.org.uk; netdev at vger.kernel.org;
> devicetree at vger.kernel.org; linux-stm32 at st-md-mailman.stormreply.com;
> linux-arm-kernel at lists.infradead.org; linux-kernel at vger.kernel.org
> Subject: Re: [PATCH v6 1/2] dt-bindings: net: Add FSD EQoS device tree
> bindings
> 
> > +  phy-mode:
> > +    enum:
> > +      - rgmii-id
> 
> phy-mode is normally a board property, in the .dts file, since the board
might
> decide to have extra long clock lines and so want 'rgmii'.
> 
> The only reason i can think of putting rgmii-id here is if the MAC only
> supports 'rgmii-id', it is impossible to make it not add delays.
> If that is true, a comment would be good.


Hi Andrew,
Thanks for reviewing.
I think we already discussed this part some time back here [1]
[1] :
https://patchwork.kernel.org/project/linux-arm-kernel/patch/20230814112539.7
0453-2-sriranjani.p at samsung.com/#25879995
Please do let me know if there is any other concern on this.

-Swathi

> 
> 	Andrew