[Intel-wired-lan] [PATCH iwl-next v4 0/9] igc: Add support for Frame Preemption feature in IGC

[Loktionov, Aleksandr]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Vladimir Oltean
> Sent: Wednesday, February 12, 2025 11:01 PM
> To: Faizal Rahim <faizal.abdul.rahim at linux.intel.com>
> Cc: Nguyen, Anthony L <anthony.l.nguyen at intel.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel at intel.com>; Andrew Lunn <andrew+netdev at lunn.ch>;
> David S . Miller <davem at davemloft.net>; Eric Dumazet
> <edumazet at google.com>; Jakub Kicinski <kuba at kernel.org>; Paolo Abeni
> <pabeni at redhat.com>; Maxime Coquelin <mcoquelin.stm32 at gmail.com>;
> Alexandre Torgue <alexandre.torgue at foss.st.com>; Simon Horman
> <horms at kernel.org>; Russell King <linux at armlinux.org.uk>; Alexei
> Starovoitov <ast at kernel.org>; Daniel Borkmann <daniel at iogearbox.net>;
> Jesper Dangaard Brouer <hawk at kernel.org>; John Fastabend
> <john.fastabend at gmail.com>; Furong Xu <0x1207 at gmail.com>; Russell King
> <rmk+kernel at armlinux.org.uk>; Serge Semin <fancer.lancer at gmail.com>;
> Xiaolei Wang <xiaolei.wang at windriver.com>; Suraj Jaiswal
> <quic_jsuraj at quicinc.com>; Kory Maincent <kory.maincent at bootlin.com>;
> Gal Pressman <gal at nvidia.com>; Jesper Nilsson <jesper.nilsson at axis.com>;
> Andrew Halaney <ahalaney at redhat.com>; Choong Yong Liang
> <yong.liang.choong at linux.intel.com>; Kunihiko Hayashi
> <hayashi.kunihiko at socionext.com>; Gomes, Vinicius
> <vinicius.gomes at intel.com>; intel-wired-lan at lists.osuosl.org;
> netdev at vger.kernel.org; linux-kernel at vger.kernel.org; linux-stm32 at st-md-
> mailman.stormreply.com; linux-arm-kernel at lists.infradead.org;
> bpf at vger.kernel.org
> Subject: Re: [Intel-wired-lan] [PATCH iwl-next v4 0/9] igc: Add support for
> Frame Preemption feature in IGC

Please start commit title from slam letters: 
Igc: add ...

> On Mon, Feb 10, 2025 at 02:01:58AM -0500, Faizal Rahim wrote:
> > Introduces support for the FPE feature in the IGC driver.
> >
> > The patches aligns with the upstream FPE API:
> >
> https://patchwork.kernel.org/project/netdevbpf/cover/20230220122343.1
> 1
> > 56614-1-vladimir.oltean at nxp.com/
> >
> https://patchwork.kernel.org/project/netdevbpf/cover/20230119122705.7
> 3
> > 054-1-vladimir.oltean at nxp.com/
> >
> > It builds upon earlier work:
> >
> https://patchwork.kernel.org/project/netdevbpf/cover/20220520011538.1
> 0
> > 98888-1-vinicius.gomes at intel.com/
> >
> > The patch series adds the following functionalities to the IGC driver:
> > a) Configure FPE using `ethtool --set-mm`.
> > b) Display FPE settings via `ethtool --show-mm`.
> > c) View FPE statistics using `ethtool --include-statistics --show-mm'.
> > e) Enable preemptible/express queue with `fp`:
> >    tc qdisc add ... root taprio \
> >    fp E E P P
> 
> Any reason why you are only enabling the preemptible traffic classes with
> taprio, and not with mqprio as well? I see there will have to be some work
> harmonizing igc's existing understanding of ring priorities with what Kurt did in
> 9f3297511dae ("igc: Add MQPRIO offload support"), and I was kind of
> expecting to see a proposal for that as part of this.