[PATCH v19 11/11] perf: arm_pmuv3: Add support for the Branch Record Buffer Extension (BRBE)
Leo Yan
leo.yan at arm.com
Wed Feb 12 11:00:05 PST 2025
On Wed, Feb 12, 2025 at 06:52:27PM +0000, Leo Yan wrote:
[...]
> > +static int brbinf_get_mispredict(u64 brbinf)
> > +{
> > + return FIELD_GET(BRBINFx_EL1_MPRED_MASK, brbinf);
> > +}
>
> I would expect the naming of brbinf_get_mispredict() will cause
> confusion. When the function returns 1, it means "Branch was
> incorrectly predicted".
>
> Maybe consider to use '!FIELD_GET(...)' for a reversed value?
Please ignore this comment. Sorry for my misreading and noise.
More information about the linux-arm-kernel
mailing list