[PATCH v2 3/3] gpio: zynq: Simplify with of_device_get_match_data()
Krzysztof Kozlowski
krzysztof.kozlowski at oss.qualcomm.com
Fri Dec 19 04:10:01 PST 2025
On 19/12/2025 11:15, Bartosz Golaszewski wrote:
> On Fri, Dec 19, 2025 at 11:12 AM Krzysztof Kozlowski
> <krzysztof.kozlowski at oss.qualcomm.com> wrote:
>>
>> Driver's probe function matches against driver's of_device_id table,
>> where each entry has non-NULL match data, so of_match_node() can be
>> simplified with of_device_get_match_data().
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at oss.qualcomm.com>
>> ---
>
> I think there are some copy-paste leftovers in your commit messages.
I just did not update the commit msg.
> You're saying you're using of_ functions but you're really going for
> the device_ ones. Also update error messages. And possibly use
> dev_err_probe() too while at it?
Sure
>
> Same elsewhere.
>
> Bart
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list