[PATCH v3 2/3] ARM: dts: exynos: Add Google Manta (Nexus 10)

[Krzysztof Kozlowski]

On 15/12/2025 21:06, David Heidelberg wrote:
>>>> +	aliases {
>>>> +		mmc0 = &mmc_0; /* eMMC */
>>>> +		mmc1 = &mmc_1; /* WiFi */
>>>> +	};
>>>> +
>>>> +	bmp180_vdda_reg: regulator-bmp180-vdda {
>>>> +		compatible = "regulator-fixed";
>>>> +		regulator-name = "BMP180_VDDA";
>>>> +	};
>>> something-something-regulator (all occurences within the DTS)
>>>
>>
>> I don't understand this suggestion.
> 
> oh right, let me clarify,
> 
> the regulator name should end with -regulator postfix.

That is not a correct suggestion for none of the SoC trees. If you
wanted to be consistent with old Exynos, then look at the sources - this
is voltage-regulator. But if we are nitpicking on that, this should be
either matching new code (regulator) or even the new style from DT bindings.

You have never reviewed anything on samsung-soc, so I wonder if this is
result of cc-ing this phone-devel. If that's the case, that list should
be just ignored.

Please do not nitpick on such stuff, especially on things not being
correct in terms of recommended style or bindings.


Best regards,
Krzysztof