[PATCH RFC 4/4] stmmac: s32: enable multi irqs mode
Jan Petrous
jan.petrous at oss.nxp.com
Mon Dec 15 06:21:49 PST 2025
On Sun, Dec 14, 2025 at 11:37:51PM +0100, Andrew Lunn wrote:
> On Sun, Dec 14, 2025 at 11:15:40PM +0100, Jan Petrous via B4 Relay wrote:
> > From: "Jan Petrous (OSS)" <jan.petrous at oss.nxp.com>
> >
> > Signalize support for multi irq mode.
> >
> > >From now, if yoused old DT node, without channel IRQs set,
> > the driver fails to init with the following error:
> >
> > [4.925420] s32-dwmac 4033c000.ethernet eth0: stmmac_request_irq_multi_msi: alloc rx-0 MSI -6 (error: -22)
>
> Sorry, but that is not acceptable. You cannot break old DT blobs.
>
> Please reverse the logic. If you find all the needed properties in DT
> enable STMMAC_FLAG_MULTI_MSI_EN. If none of the properties are there,
> continue using one interrupt, and if only some of the needed
> properties are there but some are missing, then you can error out with
> EINVAL, because the DT blob is invalid.
>
Yeh, that was the main reason of marking it as RFC, I was not sure
if I can break old DT blobs or not.
Thanks for answer. I will change the procedure to stay
backward compatible.
/Jan
More information about the linux-arm-kernel
mailing list