[PATCH v4 3/3] cpufreq: CPPC: Update FIE arch_freq_scale in ticks for non-PCC regs
Jie Zhan
zhanjie9 at hisilicon.com
Tue Dec 9 05:23:58 PST 2025
Hi Pierre,
On 12/8/2025 6:08 PM, Pierre Gondois wrote:
> Hello Jie Zhan,
>
>
> On 12/3/25 04:24, Jie Zhan wrote:
...
>> @@ -236,10 +265,8 @@ static void __init cppc_freq_invariance_init(void)
>> static void cppc_freq_invariance_exit(void)
>> {
>> - if (fie_disabled)
>> - return;
>> -
>> - kthread_destroy_worker(kworker_fie);
>> + if (kworker_fie)
>> + kthread_destroy_worker(kworker_fie);
>
> Shouldn't we have:
> kworker_fie = NULL;
> here aswell ?
>
I don't think it's needed.
This is where we unload the cppc_cpufreq module. 'kworker_fie' will no
longer be used after this, and it will be initialized to NULL again when
reloading the module.
I can't think of any other buggy scenarios.
>> }
>> #else
>
>
> Otherwise, for the 3 patches:
>
> Reviewed-by: Pierre Gondois <pierre.gondois at arm.com>
>
Thanks!
Jie
More information about the linux-arm-kernel
mailing list