[PATCH net] net: mdio: aspeed: add dummy read to avoid read-after-write issue
Jacky Chou
jacky_chou at aspeedtech.com
Tue Dec 9 03:08:34 PST 2025
Hi Andrew,
Thank you for your reply.
> >
> > Fixes: 737ca352569e ("net: mdio: aspeed: move reg accessing part into
> > separate functions")
>
> That seems like an odd Fixes: tag. That is just moving code around, but the
> write followed by a read existed before that. Why not:
>
Agreed.
I mistakenly thought I should reference the most recent integrated changes
for the Fixes: tag.
I'll correct the Fixes: tag in the next revision.
> commit f160e99462c68ab5b9e2b9097a4867459730b49a
> Author: Andrew Jeffery <andrew at aj.id.au>
> Date: Wed Jul 31 15:09:57 2019 +0930
>
> net: phy: Add mdio-aspeed
>
> The AST2600 design separates the MDIO controllers from the MAC, which
> is
> where they were placed in the AST2400 and AST2500. Further, the register
> interface is reworked again, so now we have three possible different
> interface implementations, however this driver only supports the
> interface provided by the AST2600. The AST2400 and AST2500 will
> continue
> to be supported by the MDIO support embedded in the FTGMAC100
> driver.
>
> The hardware supports both C22 and C45 mode, but for the moment only
> C22
> support is implemented.
>
> Signed-off-by: Andrew Jeffery <andrew at aj.id.au>
> Reviewed-by: Andrew Lunn <andrew at lunn.ch>
> Signed-off-by: David S. Miller <davem at davemloft.net>
Thanks,
Jacky
More information about the linux-arm-kernel
mailing list