[PATCH 03/19] coresight: trbe: Remove buffer disabling in trbe_handle_overflow()

Anshuman Khandual anshuman.khandual at arm.com
Thu Dec 4 04:31:53 PST 2025


On 01/12/25 4:51 PM, Leo Yan wrote:
> When trbe_handle_overflow() runs, the buffer has already been disabled
> and drained, so the duplicate operation is unnecessary.  Remove it.
> 
> Signed-off-by: Leo Yan <leo.yan at arm.com>
> ---
>  drivers/hwtracing/coresight/coresight-trbe.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-trbe.c b/drivers/hwtracing/coresight/coresight-trbe.c
> index 2f44e4a65e0ee2b2c8fdd06a51ab01fc57f44a4e..f5597bd9b5fba9a8f5053d5823b03380fd468b5c 100644
> --- a/drivers/hwtracing/coresight/coresight-trbe.c
> +++ b/drivers/hwtracing/coresight/coresight-trbe.c
> @@ -1077,7 +1077,6 @@ static int trbe_handle_overflow(struct perf_output_handle *handle)
>  		 * is able to detect this with a disconnected handle
>  		 * (handle->event = NULL).
>  		 */
> -		trbe_drain_and_disable_local(buf->cpudata);
>  		*this_cpu_ptr(buf->cpudata->drvdata->handle) = NULL;
>  		return -EINVAL;
>  	}
> 

Like the previous patch - trbe_drain_and_disable_local() would have run
if TRBE_FAULT_ACT_WRAP case is being handled via trbe_handle_overflow().
But please do mention these details in the commit message for things to
be clear and explicit.

Reviewed-by: Anshuman Khandual <anshuman.khandual at arm.com>



More information about the linux-arm-kernel mailing list