[PATCH RFC net-next 00/15] net: stmmac: rk: cleanups galore

[Jacob Keller]

On 12/1/2025 8:44 AM, Russell King (Oracle) wrote:
> Again, I don't like this foo_enable() / foo_power_on() pattern with
> a true/false argument - when false, the function is not enabling
> nor "on"-ing, but disabling or "off"-ing. So, gmac_clk_enable() is
> going to get split up and renamed.
> 

Agreed, removing this anti-pattern is good. It makes the logic more
difficult to follow and understand than well named functions.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 236 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20251203/5dd8ffb3/attachment-0001.sig>