[PATCH net-next v2 3/3] net: stmmac: Set CIC bit only for TX queues with COE
Jakub Kicinski
kuba at kernel.org
Wed Aug 20 08:56:52 PDT 2025
On Wed, 20 Aug 2025 08:54:46 -0700 Jakub Kicinski wrote:
> On Wed, 20 Aug 2025 12:44:18 +0530 G Thomas, Rohan wrote:
> > On 8/20/2025 6:52 AM, Jakub Kicinski wrote:
> > > Hopefully the slight pointer chasing here doesn't impact performance?
> > > XDP itself doesn't support checksum so perhaps we could always pass
> > > false?
> >
> > I'm not certain whether some XDP applications might be benefiting from
> > checksum offloading currently
>
> Checksum offload is not supported in real XDP, AFAIK, and in AF_XDP
> the driver must implement a checksum callback which stmmac does not do.
> IOW it's not possible to use Tx checksum offload in stmmac today from
> XDP.
To be clear -- this is just for context. I don't understand the details
of what the CIC bit controls, so the final decision is up to you.
More information about the linux-arm-kernel
mailing list