[PATCH net-next v2 01/10] dt-bindings: net: sun8i-emac: Add A523 GMAC200 compatible

Rob Herring (Arm) robh at kernel.org
Wed Aug 13 09:40:00 PDT 2025


On Wed, 13 Aug 2025 22:55:31 +0800, Chen-Yu Tsai wrote:
> From: Chen-Yu Tsai <wens at csie.org>
> 
> The Allwinner A523 SoC family has a second Ethernet controller, called
> the GMAC200 in the BSP and T527 datasheet, and referred to as GMAC1 for
> numbering. This controller, according to BSP sources, is fully
> compatible with a slightly newer version of the Synopsys DWMAC core.
> The glue layer around the controller is the same as found around older
> DWMAC cores on Allwinner SoCs. The only slight difference is that since
> this is the second controller on the SoC, the register for the clock
> delay controls is at a different offset. Last, the integration includes
> a dedicated clock gate for the memory bus and the whole thing is put in
> a separately controllable power domain.
> 
> Add a compatible string entry for it, and work in the requirements for
> a second clock and a power domain.
> 
> Signed-off-by: Chen-Yu Tsai <wens at csie.org>
> ---
> Changes since v1:
> - Switch to generic (tx|rx)-internal-delay-ps properties
> ---
>  .../net/allwinner,sun8i-a83t-emac.yaml        | 81 ++++++++++++++++++-
>  1 file changed, 79 insertions(+), 2 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/toshiba,visconti-dwmac.example.dtb: ethernet at 28000000 (toshiba,visconti-dwmac): clock-names: ['stmmaceth', 'phy_ref_clk'] is too long
	from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/toshiba,visconti-dwmac.example.dtb: ethernet at 28000000 (toshiba,visconti-dwmac): clocks: [[4294967295, 28], [4294967295, 118]] is too long
	from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/toshiba,visconti-dwmac.example.dtb: ethernet at 28000000 (toshiba,visconti-dwmac): compatible: 'oneOf' conditional failed, one must be fixed:
	['toshiba,visconti-dwmac', 'snps,dwmac-4.20a'] is too long
	'allwinner,sun8i-a83t-emac' was expected
	'allwinner,sun8i-h3-emac' was expected
	'allwinner,sun8i-r40-gmac' was expected
	'allwinner,sun8i-v3s-emac' was expected
	'allwinner,sun50i-a64-emac' was expected
	'toshiba,visconti-dwmac' is not one of ['allwinner,sun20i-d1-emac', 'allwinner,sun50i-a100-emac', 'allwinner,sun50i-h6-emac', 'allwinner,sun50i-h616-emac0', 'allwinner,sun55i-a523-gmac0']
	'allwinner,sun55i-a523-gmac200' was expected
	from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/toshiba,visconti-dwmac.example.dtb: ethernet at 28000000 (toshiba,visconti-dwmac): 'resets' is a required property
	from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/toshiba,visconti-dwmac.example.dtb: ethernet at 28000000 (toshiba,visconti-dwmac): 'reset-names' is a required property
	from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/toshiba,visconti-dwmac.example.dtb: ethernet at 28000000 (toshiba,visconti-dwmac): 'syscon' is a required property
	from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/stm32-dwmac.example.dtb: ethernet at 5800a000 (st,stm32mp1-dwmac): clock-names: ['stmmaceth', 'mac-clk-tx', 'mac-clk-rx', 'ethstp', 'eth-ck'] is too long
	from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/stm32-dwmac.example.dtb: ethernet at 5800a000 (st,stm32mp1-dwmac): clocks: [[4294967295, 105], [4294967295, 103], [4294967295, 104], [4294967295, 112], [4294967295, 123]] is too long
	from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/stm32-dwmac.example.dtb: ethernet at 5800a000 (st,stm32mp1-dwmac): clock-names: ['stmmaceth', 'mac-clk-tx', 'mac-clk-rx', 'ethstp', 'eth-ck'] is too long
	from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/stm32-dwmac.example.dtb: ethernet at 5800a000 (st,stm32mp1-dwmac): clocks: [[4294967295, 105], [4294967295, 103], [4294967295, 104], [4294967295, 112], [4294967295, 123]] is too long
	from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/stm32-dwmac.example.dtb: ethernet at 5800a000 (st,stm32mp1-dwmac): compatible: 'oneOf' conditional failed, one must be fixed:
	['st,stm32mp1-dwmac', 'snps,dwmac-4.20a'] is too long
	'allwinner,sun8i-a83t-emac' was expected
	'allwinner,sun8i-h3-emac' was expected
	'allwinner,sun8i-r40-gmac' was expected
	'allwinner,sun8i-v3s-emac' was expected
	'allwinner,sun50i-a64-emac' was expected
	'st,stm32mp1-dwmac' is not one of ['allwinner,sun20i-d1-emac', 'allwinner,sun50i-a100-emac', 'allwinner,sun50i-h6-emac', 'allwinner,sun50i-h616-emac0', 'allwinner,sun55i-a523-gmac0']
	'allwinner,sun55i-a523-gmac200' was expected
	from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/stm32-dwmac.example.dtb: ethernet at 5800a000 (st,stm32mp1-dwmac): 'resets' is a required property
	from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/stm32-dwmac.example.dtb: ethernet at 5800a000 (st,stm32mp1-dwmac): 'reset-names' is a required property
	from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/stm32-dwmac.example.dtb: ethernet at 5800a000 (st,stm32mp1-dwmac): 'phy-handle' is a required property
	from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/stm32-dwmac.example.dtb: ethernet at 5800a000 (st,stm32mp1-dwmac): 'syscon' is a required property
	from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/stm32-dwmac.example.dtb: ethernet at 5800a000 (st,stm32mp1-dwmac): Unevaluated properties are not allowed ('reg-names', 'st,syscon' were unexpected)
	from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet at 1101c000 (mediatek,mt2712-gmac): clock-names:0: 'stmmaceth' was expected
	from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet at 1101c000 (mediatek,mt2712-gmac): clock-names: ['axi', 'apb', 'mac_main', 'ptp_ref', 'rmii_internal'] is too long
	from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet at 1101c000 (mediatek,mt2712-gmac): clocks: [[4294967295, 34], [4294967295, 37], [4294967295, 154], [4294967295, 155], [4294967295, 158]] is too long
	from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet at 1101c000 (mediatek,mt2712-gmac): power-domains: False schema does not allow [[4294967295, 4]]
	from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet at 1101c000 (mediatek,mt2712-gmac): clock-names: ['axi', 'apb', 'mac_main', 'ptp_ref', 'rmii_internal'] is too long
	from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet at 1101c000 (mediatek,mt2712-gmac): clocks: [[4294967295, 34], [4294967295, 37], [4294967295, 154], [4294967295, 155], [4294967295, 158]] is too long
	from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet at 1101c000 (mediatek,mt2712-gmac): compatible: 'oneOf' conditional failed, one must be fixed:
	['mediatek,mt2712-gmac', 'snps,dwmac-4.20a'] is too long
	'allwinner,sun8i-a83t-emac' was expected
	'allwinner,sun8i-h3-emac' was expected
	'allwinner,sun8i-r40-gmac' was expected
	'allwinner,sun8i-v3s-emac' was expected
	'allwinner,sun50i-a64-emac' was expected
	'mediatek,mt2712-gmac' is not one of ['allwinner,sun20i-d1-emac', 'allwinner,sun50i-a100-emac', 'allwinner,sun50i-h6-emac', 'allwinner,sun50i-h616-emac0', 'allwinner,sun55i-a523-gmac0']
	'allwinner,sun55i-a523-gmac200' was expected
	from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet at 1101c000 (mediatek,mt2712-gmac): 'resets' is a required property
	from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet at 1101c000 (mediatek,mt2712-gmac): 'reset-names' is a required property
	from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet at 1101c000 (mediatek,mt2712-gmac): 'phy-handle' is a required property
	from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet at 1101c000 (mediatek,mt2712-gmac): 'syscon' is a required property
	from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: ethernet at 1101c000 (mediatek,mt2712-gmac): Unevaluated properties are not allowed ('mediatek,pericfg', 'mediatek,tx-delay-ps' were unexpected)
	from schema $id: http://devicetree.org/schemas/net/allwinner,sun8i-a83t-emac.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250813145540.2577789-2-wens@kernel.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.




More information about the linux-arm-kernel mailing list